Re: [PATCH v2 05/17] i2c: omap: split out [XR]DR and [XR]RDY

From: Felipe Balbi
Date: Mon Jul 02 2012 - 07:35:54 EST


On Tue, Jun 26, 2012 at 04:11:30PM +0530, Shubhrajyoti wrote:
> Hi Felipe,
> On Thursday 14 June 2012 09:54 PM, Felipe Balbi wrote:
> > return IRQ_HANDLED;
> > }
> >
> > - if (stat & (OMAP_I2C_STAT_RRDY | OMAP_I2C_STAT_RDR)) {
> > + if (stat & OMAP_I2C_STAT_RDR) {
> > u8 num_bytes = 1;
> >
> > + if (dev->fifo_size)
> > + num_bytes = dev->fifo_size;
> In case of a draining interrupt. The byte count may not be the fifo size.
> Do you agree?

hmm... indeed, that should be dev->buf_len... can you fix that up or
want me to resend ?

--
balbi

Attachment: signature.asc
Description: Digital signature