Re: [net-next RFC V5 5/5] virtio_net: support negotiating the numberof queues through ctrl vq

[Jason Wang]

On 07/06/2012 04:07 AM, Amos Kong wrote:
> On 07/05/2012 08:51 PM, Sasha Levin wrote:
> > On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote:
> > > @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev)
> > >          if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ))
> > >                  vi->has_cvq = true;
>
> > > +       /* Use single tx/rx queue pair as default */
> > > +       vi->num_queue_pairs = 1;
> > > +       vi->total_queue_pairs = num_queue_pairs;
> vi->total_queue_pairs also should be set to 1
>
>             vi->total_queue_pairs = 1;

Hi Amos:

total_queue_pairs is the max number of queue pairs that the deivce could 
provide, so it's ok here.
> > The code is using this "default" even if the amount of queue pairs it
> > wants was specified during initialization. This basically limits any
> > device to use 1 pair when starting up.
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/