Re: [PATCH 01/19] Staging: xgifb: Comment cleaning.

[Miguel GÃmez]

Hi!

> > diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> []
> > @@ -1,9 +1,3 @@
> > -/*
> > - * XG20, XG21, XG40, XG42 frame buffer device
> > - * for Linux kernels  2.5.x, 2.6.x
> > - * Base on TW's sis fbdev code.
> > - */
>
> Maybe the comment removal is a bit aggressive.
> Perhaps two of these are relevant comments.
>
> > diff --git a/drivers/staging/xgifb/vgatypes.h b/drivers/staging/xgifb/vgatypes.h
> []
> > @@ -79,7 +79,4 @@ struct xgi_hw_device_info {
> >   	unsigned long ulCRT2LCDType; /* defined in the data structure type */
> >   };
> >
> > -/* Additional IOCTL for communication xgifb <> X driver        */
> > -/* If changing this, xgifb.h must also be changed (for xgifb) */
> >   #endif
> > -
>
> Maybe this too.

Yes, true, Point taken :)

>  From a quick glance, the rest of the patches look like
> nice cleanups.
>
> btw: most kernel code uses logical line continuations
> at the end of the line not at the beginning of the next
> line.
>
> ie:
> 	if (foo &&
> 	    bar)
> not
> 	if (foo
> 	    && bar)

Thanks for the tip! I wasn't really sure about the preferred way to do it.

Regards!

--
Miguel GÃmez
Igalia - http://www.igalia.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/