Re: [PATCH 0/6] staging: vt6655: Cleanup in usage of macros

[Joe Perches]

On Sun, 2012-07-08 at 23:51 -0300, Marcos Paulo de Souza wrote:
> Hi kernel guys!
> 
> This patchset aims to clean all unused and commented macros.
> 
> For this challenge, forgotten-macros tool helped us.

Perhaps there may be false positives in your code.

Many times, macros like the below are used:

#define SUBSYSTEM_PREFIX_FOO	1
#define SUBSYSTEM_PREFIX_BAR	2
#define SUBSYSTEM_PREFIX_BAZ	3

#define USE_TYPE(type)	SUBSYSTEM_PREFIX_##type

It doesn't seem your code knows that style.

Also, the tool might be more flexible if it was
written using perl or python.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/