Re: [PATCH] mm/hugetlb: split outis_hugetlb_entry_migration_or_hwpoison

From: David Rientjes
Date: Mon Jul 09 2012 - 06:43:45 EST


On Mon, 9 Jul 2012, Wanpeng Li wrote:

> From: Wanpeng Li <liwp@xxxxxxxxxxxxxxxxxx>
>
> Code was duplicated in two functions, clean it up.
>
> Signed-off-by: Wanpeng Li <liwp.linux@xxxxxxxxx>
> ---
> mm/hugetlb.c | 20 +++++++++-----------
> 1 files changed, 9 insertions(+), 11 deletions(-)

Nack, this makes the code more convoluted then the hugetlb code already is
and savings two lines of code isn't worth it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/