Re: [PATCH 6/7] drivers/net/ethernet/broadcom/cnic.c: removeinvalid reference to list iterator variable

From: David Miller
Date: Mon Jul 09 2012 - 18:25:04 EST


From: Julia Lawall <Julia.Lawall@xxxxxxx>
Date: Sun, 8 Jul 2012 13:37:43 +0200

> From: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> If list_for_each_entry, etc complete a traversal of the list, the iterator
> variable ends up pointing to an address at an offset from the list head,
> and not a meaningful structure. Thus this value should not be used after
> the end of the iterator. There does not seem to be a meaningful value to
> provide to netdev_warn. Replace with pr_warn, since pr_err is used
> elsewhere.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/