Re: [PATCHv3 1/4] staging: OMAP4+: thermal: introduce bandgaptemperature sensor

[Valentin, Eduardo]

Hello Greg,

On Thu, Jul 12, 2012 at 5:45 AM, Valentin, Eduardo
<eduardo.valentin@xxxxxx> wrote:
> Hello,
>
> On Thu, Jul 12, 2012 at 3:32 AM, Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> On Wed, Jul 11, 2012 at 11:41:06PM +0300, Eduardo Valentin wrote:
>>> In the System Control Module, OMAP supplies a voltage reference
>>> and a temperature sensor feature that are gathered in the band
>>> gap voltage and temperature sensor (VBGAPTS) module. The band
>>> gap provides current and voltage reference for its internal
>>> circuits and other analog IP blocks. The analog-to-digital
>>> converter (ADC) produces an output value that is proportional
>>> to the silicon temperature.
>>>
>>> This patch provides a platform driver which expose this feature.
>>> It is moduled as a MFD child of the System Control Module core
>>> MFD driver.
>>>
>>> This driver provides only APIs to access the device properties,
>>> like temperature, thresholds and update rate.
>>>
>>> Signed-off-by: Eduardo Valentin <eduardo.valentin@xxxxxx>
>>> Signed-off-by: J Keerthy <j-keerthy@xxxxxx>
>>
>> This patch gives me the following build error:
>>
>> rivers/staging/omap-thermal/omap-bandgap.c: In function ‘omap_bandgap_build’:
>> drivers/staging/omap-thermal/omap-bandgap.c:805:2: error: implicit declaration of function ‘of_match_device’ [-Werror=implicit-function-declaration]
>> drivers/staging/omap-thermal/omap-bandgap.c:805:8: warning: assignment makes pointer from integer without a cast [enabled by default]
>
> OK. Those I didn't see while testing on my side. I didn't use
> -Werror=implicit-function-declaration though.
>

Actually this is put to all compilation processes, no matter what.
Thing is that my codesourcery toolchain is somehow ignoring this flag.
That's why I didn't see it. Besides this driver should not compile for
x86 arch. So, I fixed that up and will resend soon. Hope it doesnt
break things a part this time...

>>
>> So of course I can't accept it :(
>
> That's for sure.

Sorry for this mess.
>
>>
>> How hard is it to test that the patches build before sending them to me?
>
> It should not be. I will check with those compiling flags.
>
>>
>> ugh,
>>
>> greg k-h
>
>
>
> --
>
> Eduardo Valentin



-- 

Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/