Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

From: Lee Jones
Date: Fri Jul 13 2012 - 07:56:42 EST


@@ -964,11 +966,13 @@ static int __devinit ab8500_btemp_probe(struct platform_device *pdev)
{
int irq, i, ret = 0;
u8 val;
- struct abx500_bm_plat_data *plat_data = pdev->dev.platform_data;

I already told you about this.
your previous comment was: "No, it's meant to work with _both_ platform
and Device Tree registation."

Right.

Why is this required when platform specific information/file is removed?

It's not being removed, it's just not allowed to be upstreamed. Once we enforce Device Tree only booting, we'll go round and remove that capability from the drivers. Until then, you must ensure all Device Tree enablement works in parallel with platform registration.

Concentrate on enabling the drivers for DT for now and we'll extract platform data support later.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/