Re: [PATCH] mfd: add tps65910 32-kHz-crystal-input init
From: Samuel Ortiz
Date: Mon Jul 16 2012 - 09:44:00 EST
Hi Johan,
On Wed, Jul 11, 2012 at 03:44:33PM +0200, Johan Hovold wrote:
> Replace tps65910_misc_init with a dedicated init function for the
> 32-kHz-crystal input.
>
> Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
> ---
>
> Hi Samuel,
>
> How about something like this? My thought with misc_init was that it could be
> extended should more simple initialisation like for the ck32k_xtal need to be
> done, but perhaps it's cleaner to stick with dedicated init functions
> through-out. At least for now.
Yes, it's clearer, at least to me.
I applied this patch, thanks for following up.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/