Re: feature-removal-schedule entry from 2009

[Theodore Ts'o]

On Sun, Jul 15, 2012 at 03:41:53PM -0500, Rob Landley wrote:
> Does it become a "please add a call to sample_interrupt_randomness()"
> reminder, or will the infrastructure figure out when to do that outside
> the driver?

The patches in the random.git tree unconditionally call
add_interrupt_randomness() in handle_irq_event_percpu(), so the
drivers don't need to do anything at this point.

> And will this upcoming patch set remove 'em, or leave the NOP debris
> there?

The current status is here:

http://git.kernel.org/?p=linux/kernel/git/tytso/random.git;a=summary

At this point the flag is a no-op, and can be removed.  This close to
the merge window, I don't think I'm going to have time to create
patches which remove the flag from all of the drivers, but it's
basically clean up work, and having the extra bit set isn't going to
harm anyone.

The only thing that might require a bit of care is the usage in
arch/um, where someone needs to do a bit more analysis to see if it's
just a matter of removing the flag from the call to request_irq().  My
current thinking was to merge the new interrupt structure during this
merge window, and then clean up the NOP debris during the next
development cycle.

						- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/