Re: [Regression][Revert request] Excessive delay or hang during resumefrom system suspend due to a hrtimer commit

[John Stultz]

On 07/16/2012 04:26 AM, Thomas Gleixner wrote:
> On Mon, 16 Jul 2012, Thomas Gleixner wrote:
>
> > On Mon, 16 Jul 2012, Rafael J. Wysocki wrote:
> >
> > > On Monday, July 16, 2012, Thomas Gleixner wrote:
> > > > On Sun, 15 Jul 2012, Rafael J. Wysocki wrote:
> > > > > To everyone involved: the fact that this change, which was likely to introduce
> > > > > regressions from the look of it alone, has been pushed to Linus (an to -stable
> > > > > at the same time!) so late in the cycle, is seriuosly disappointing.
> > > > Well, we spent an massive amount of time in testing, reviewing and
> > > > discussion and it definitely did not break suspend/resume here.
> > > I'm not saying that you didn't consider it thoroughly, but unfortunately you
> > > did overlook this particular issue, didn't you?
> > >
> > > > This was not pushed without a lot of thoughts and in fact what you are
> > > > seing is another long standing bug in the timekeeping resume code,
> > > > which was just papered over by the incorrect handling of the clock was
> > > > set cases in the other parts of the system.
> > > >
> > > > Does the following patch fix the problem for you ?
> > > Yes, it does, thanks!
> > >
> > > > @John: Should that clear ntp as well or is it enough to set ntp_error
> > > >         to 0 ?
> > > >
> > > > /me really goes on vacation now.
> > > So who's going to take care of the patch? :-)
> > I'm still packing gear. So i'll push it into timers/urgent.
> Actually that's a bad idea. John want's to double check vs. the
> ntp_clear question. So John can send it to linus directly.
>
> @John: Should it be: timekeeping_update(true)
I think its better to leave it as false, so we don't reset the NTP state 
machine completely after suspend.

When we come back from suspend our error is usually off by the 
persistent_clock/rtc granularity, so it might make sense, but I'd want a 
lot more testing of using ntp over suspend before changing the existing 
behavior of not doing it.

> Now I'm gone for real.
Ok. Thanks for spinning this up so quickly. I'll go ahead and send it on 
to Linus.

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/