Re: [PATCH RFC V4 3/3] kvm: Choose better candidate for directedyield

[Rik van Riel]

On 07/16/2012 06:07 AM, Avi Kivity wrote:

> > +{
> > +	bool eligible;
> > +
> > +	eligible = !vcpu->ple.cpu_relax_intercepted ||
> > +			(vcpu->ple.cpu_relax_intercepted&&
> > +			 vcpu->ple.dy_eligible);
> > +
> > +	if (vcpu->ple.cpu_relax_intercepted)
> > +		vcpu->ple.dy_eligible = !vcpu->ple.dy_eligible;
>
> Probably should assign 'true', since the previous value is essentially
> random.

I suspect the intended purpose of this conditional is to
flip the eligibility of a vcpu for being selected as a
direct yield target.

In other words, that bit of the code is correct.

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/