[PATCH] uprobe: checking probe event include directory

[Jovi Zhang]

Currently below command run successful:
$ echo 'p /bin:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events

this don't make sense, because /bin is a directory,
so make this checking earily, not report error untill probe enable.

Signed-off-by: Jovi Zhang <bookjovi@xxxxxxxxx>
---
 kernel/trace/trace_uprobe.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 85158fa..cf382de 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -259,6 +259,11 @@ static int create_trace_uprobe(int argc, char **argv)
 		goto fail_address_parse;

 	inode = igrab(path.dentry->d_inode);
+	 if (S_ISDIR(inode->i_mode)) {
+		ret = -EINVAL;
+		pr_info("probe file cannot be directory.\n");
+		goto fail_address_parse;
+	}

 	argc -= 2;
 	argv += 2;
-- 
1.7.9.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/