RE: [PATCH v7 2/5] powerpc/85xx: add HOTPLUG_CPU support

[Zhao Chenhui-B35336]

> -----Original Message-----
> From: Kumar Gala [mailto:galak@xxxxxxxxxxxxxxxxxxx]
> Sent: Friday, July 13, 2012 8:15 PM
> To: Zhao Chenhui-B35336
> Cc: linuxppc-dev@xxxxxxxxxxxxxxxx; Wood Scott-B07421; linux-kernel@xxxxxxxxxxxxxxx; Li Yang-R58472
> Subject: Re: [PATCH v7 2/5] powerpc/85xx: add HOTPLUG_CPU support
> 
> 
> On Jul 3, 2012, at 5:21 AM, Zhao Chenhui wrote:
> 
> > From: Li Yang <leoli@xxxxxxxxxxxxx>
> >
> > Add support to disable and re-enable individual cores at runtime
> > on MPC85xx/QorIQ SMP machines. Currently support e500v1/e500v2 core.
> >
> > MPC85xx machines use ePAPR spin-table in boot page for CPU kick-off.
> > This patch uses the boot page from bootloader to boot core at runtime.
> > It supports 32-bit and 36-bit physical address.
> >
> > Add generic_set_cpu_up() to set cpu_state as CPU_UP_PREPARE in kick_cpu().
> 
> Shouldn't the generic_setup_cpu_up() be a separate patch, and refactor smp_generic_kick_cpu() to use
> it.
> 
> Also, we should pull the conversion of the spintable from #defines to struct into a separate patch
> before this one.
> 

Ok. I will split this patch.

-Chenhui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/