Re: [PATCH 2/4 v2] mm: fix possible incorrect return value ofmigrate_pages() syscall

From: Christoph Lameter
Date: Tue Jul 17 2012 - 10:28:09 EST


On Tue, 17 Jul 2012, Joonsoo Kim wrote:

> @@ -1382,6 +1382,8 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned long, maxnode,
>
> err = do_migrate_pages(mm, old, new,
> capable(CAP_SYS_NICE) ? MPOL_MF_MOVE_ALL : MPOL_MF_MOVE);
> + if (err > 0)
> + err = -EBUSY;
>
> mmput(mm);
> out:

Why not have do_migrate_pages() return EBUSY if we do not need the number
of failed/retried pages?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/