Re: [PATCH 04/17] pda_power: remove IRQF_SAMPLE_RANDOM which is nowa no-op

[Anton Vorontsov]

On Tue, Jul 17, 2012 at 05:32:23PM -0400, Theodore Ts'o wrote:
> With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> no-op; interrupt randomness is now collected unconditionally in a very
> low-overhead fashion; see commit 775f4b297b.  The IRQF_SAMPLE_RANDOM
> flag was scheduled to be removed in 2009 on the
> feature-removal-schedule, so this patch is preparation for the final
> removal of this flag.
> 
> Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
> Cc: Anton Vorontsov <cbou@xxxxxxx>
> Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> ---

Applied, thanks!

>  drivers/power/pda_power.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c
> index 214468f..db5c526 100644
> --- a/drivers/power/pda_power.c
> +++ b/drivers/power/pda_power.c
> @@ -24,11 +24,7 @@
>  
>  static inline unsigned int get_irq_flags(struct resource *res)
>  {
> -	unsigned int flags = IRQF_SAMPLE_RANDOM | IRQF_SHARED;
> -
> -	flags |= res->flags & IRQF_TRIGGER_MASK;
> -
> -	return flags;
> +	return IRQF_SHARED | (res->flags & IRQF_TRIGGER_MASK);
>  }
>  
>  static struct device *dev;

-- 
Anton Vorontsov
Email: cbouatmailru@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/