Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve APIcompatibility

[Guennadi Liakhovetski]

Hi Vinod

On Wed, 18 Jul 2012, Vinod Koul wrote:

> On Mon, 2012-07-16 at 14:47 +0200, Guennadi Liakhovetski wrote:
> > > > Yes, that's right - these values have to be written to DMAC channel 
> > > > configuration registers, so, we do not have to change anything, those 
> > > > values can remain DMAC parameters and be passed to it directly from 
> > > > platform data.
> > > Can you get that in future fixes.
> > 
> > Sorry, what exactly would you like to have fixed here? Above I just 
> > described how the driver already functions, what changes do you see 
> > necessary? 
> Why should client pass these two values. So the parameters which can be
> calculated should be, and rest should dmacs platform data and not
> clients.

Hm, let me try again:

> > > > those
> > > > values can remain DMAC parameters and be passed to it directly from
> > > > platform data.

i.e., from DMAC's platform data, they are _not_ passed from clients. Am I 
still missing something?

> And after the removal of the slave and adddr fields, you find that you
> no longer need your specific slave structure and that can be elimnated
> completely.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/