Re: [PATCH] rbtree: fix jffs2 build issue due to renamed__rb_parent_color field

From: David Woodhouse
Date: Wed Jul 18 2012 - 07:41:27 EST


On Wed, 2012-07-18 at 04:31 -0700, Michel Lespinasse wrote:
> Fix this and add a comment explaining why this direct use is safe
> here.

Note that there was already a comment which was *intended* to have that
effect, right before the assignment:

/* Colour doesn't matter now. Only the parent pointer. */

If you're going to make that comment redundant, you might as well remove
it. And you might as well say that the trees are being *destroyed*
(consumed) at this point, rather than just that there will be no further
insert or erase operations.

--
dwmw2

Attachment: smime.p7s
Description: S/MIME cryptographic signature