Re: [PATCH 06/34] vmscan: add shrink_slab tracepoints

From: Jonathan Nieder
Date: Fri Jul 20 2012 - 11:54:23 EST


Mel Gorman wrote:
> On Thu, Jul 19, 2012 at 05:07:21PM -0500, Jonathan Nieder wrote:

>> Some of the other patches of this type made sense, but I'd personally
>> prefer if this one was dropped, yes. Though I am just a nobody that
>> reads patches rather than one of the relevant people. ;-)
>
> It's a valid point but I'm going to leave it in for now and see what the
> general opinion is.

Ok. To be more precise, this patch has two properties that other patches
of the "make later patches easier to apply" class tend not to:

* it introduces a significant functional change (adding tracepoints)
* it would have been very easy to skip

Have fun, and sorry for not explaining my reasoning before.

Ciao,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/