[PATCH] drm, ast_fb: Fix a small leak in astfb_create()

From: Jesper Juhl
Date: Fri Jul 20 2012 - 14:46:26 EST


We have this code:

...
sysram = vmalloc(size);
if (!sysram)
return -ENOMEM;

info = framebuffer_alloc(0, device);
if (!info) {
ret = -ENOMEM;
goto out;
}
...

We'll leak the memory allocated to 'sysram' if the framebuffer_alloc()
call fails and the variable goes out of scope.

Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
---
drivers/gpu/drm/ast/ast_fb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index 2fc8e9e..260a760 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -180,6 +180,7 @@ static int astfb_create(struct ast_fbdev *afbdev,

info = framebuffer_alloc(0, device);
if (!info) {
+ vfree(sysram);
ret = -ENOMEM;
goto out;
}
--
1.7.11.2


--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/