Re: [PATCH 1/2] staging/iio: use module_platform_driver macro
From: Jonathan Cameron
Date: Sun Jul 22 2012 - 15:28:10 EST
On 07/21/2012 09:54 AM, Devendra Naga wrote:
> the code which under _init and _exit does only the platform_driver_register
> and platform_driver_unregister, and nothing else,
> so its better to use the module_platform_driver macro rather duplicating
> its implementation
>
> Signed-off-by: Devendra Naga <develkernel412222@xxxxxxxxx>
Thanks.
Queued this up for when I resume sending pull requests to Greg
post merge window.
> ---
>
> drivers/staging/iio/iio_hwmon.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/staging/iio/iio_hwmon.c b/drivers/staging/iio/iio_hwmon.c
> index 27d27ec..4bb017a 100644
> --- a/drivers/staging/iio/iio_hwmon.c
> +++ b/drivers/staging/iio/iio_hwmon.c
> @@ -215,17 +215,7 @@ static struct platform_driver __refdata iio_hwmon_driver = {
> .remove = __devexit_p(iio_hwmon_remove),
> };
>
> -static int iio_inkern_init(void)
> -{
> - return platform_driver_register(&iio_hwmon_driver);
> -}
> -module_init(iio_inkern_init);
> -
> -static void iio_inkern_exit(void)
> -{
> - platform_driver_unregister(&iio_hwmon_driver);
> -}
> -module_exit(iio_inkern_exit);
> +module_platform_driver(iio_hwmon_driver);
>
> MODULE_AUTHOR("Jonathan Cameron <jic23@xxxxxxxxx>");
> MODULE_DESCRIPTION("IIO to hwmon driver");
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/