Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

[Rusty Russell]

On Thu, 19 Jul 2012 17:55:10 +0800, <wei_wang@xxxxxxxxxxxxxx> wrote:
> From: Wei WANG <wei_wang@xxxxxxxxxxxxxx>
> 
> Realtek PCI-E card reader driver adapts requests from upper-level
> sdmmc/memstick layer to the real physical card reader.

> +static int msi_en = 1;
> +module_param(msi_en, int, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(msi_en, "Enable MSI");
> +
> +static int adma_mode = 1;
> +module_param(adma_mode, int, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(adma_mode, "ADMA Mode");

These seem like they should be bool?

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/