Re: [PATCH 09/11] perf top: error handling for counter creation shouldparallel perf-record
From: David Ahern
Date: Tue Jul 24 2012 - 10:01:37 EST
On 7/23/12 12:15 PM, Arnaldo Carvalho de Melo wrote:
Em Fri, Jul 20, 2012 at 05:25:54PM -0600, David Ahern escreveu:
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index e3cab5f..0ce665c 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -943,8 +943,10 @@ try_again:
* based cpu-clock-tick sw counter, which
* is always available even if no PMU support:
*/
- if (attr->type == PERF_TYPE_HARDWARE &&
- attr->config == PERF_COUNT_HW_CPU_CYCLES) {
+ if ((err == ENOENT || err == ENXIO)
+ && attr->type == PERF_TYPE_HARDWARE
+ && attr->config == PERF_COUNT_HW_CPU_CYCLES) {
+
usual style:
if ((err == ENOENT || err == ENXIO) &&
attr->type == PERF_TYPE_HARDWARE &&
attr->config == PERF_COUNT_HW_CPU_CYCLES) {
Right. I literally made it the same as builtin-record.c. I'll resubmit.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/