Re: [PATCH v2 1/4] ACPI: Add acpi_pr_<level>() interfaces

[Joe Perches]

On Fri, 2012-07-20 at 10:54 -0600, Toshi Kani wrote:
> This patch introduces acpi_pr_<level>(), where <level> is a message
> level such as err/warn/info, to support improved logging messages
> for ACPI, esp. in hotplug operations.  acpi_pr_<level>() appends
> "ACPI" prefix and ACPI object path to the messages.  This improves
> diagnostics in hotplug operations since it identifies an object that
> caused an issue in a log file.

trivia:

> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
[]
> @@ -454,3 +454,37 @@ acpi_evaluate_hotplug_ost(acpi_handle handle, u32 source_event,
[]
> +	char *path;

const ?

> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
[]
> @@ -85,6 +85,26 @@ struct acpi_pld {
[]
> +#define acpi_pr_debug(handle, fmt, ...)				\
> +	acpi_printk(KERN_DEBUG, handle, fmt, ##__VA_ARGS__)

Might be nicer if this somehow had a dynamic debug
mechanism too.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/