Remove unnecessary WARN_ONCE's from tracing_buffers_splice_read

From: Dave Jones
Date: Wed Jul 25 2012 - 11:39:11 EST


WARN shouldn't be used as a means of communicating failure to a userspace programmer.

Signed-off-by: Dave Jones <davej@xxxxxxxxxx>

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index ed7b5d1..a745317 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -4136,13 +4136,11 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos,
return -ENOMEM;

if (*ppos & (PAGE_SIZE - 1)) {
- WARN_ONCE(1, "Ftrace: previous read must page-align\n");
ret = -EINVAL;
goto out;
}

if (len & (PAGE_SIZE - 1)) {
- WARN_ONCE(1, "Ftrace: splice_read should page-align\n");
if (len < PAGE_SIZE) {
ret = -EINVAL;
goto out;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/