Re: [PATCH v2 1/4] ACPI: Add acpi_pr_<level>() interfaces
From: Toshi Kani
Date: Wed Jul 25 2012 - 14:34:53 EST
On Wed, 2012-07-25 at 11:11 -0700, Joe Perches wrote:
> On Wed, 2012-07-25 at 11:53 -0600, Toshi Kani wrote:
> > On Wed, 2012-07-25 at 00:06 -0700, Joe Perches wrote:
> > > On Fri, 2012-07-20 at 10:54 -0600, Toshi Kani wrote:
> > > > This patch introduces acpi_pr_<level>(), where <level> is a message
> > > > level such as err/warn/info, to support improved logging messages
> > > > for ACPI, esp. in hotplug operations. acpi_pr_<level>() appends
> > > > "ACPI" prefix and ACPI object path to the messages. This improves
> > > > diagnostics in hotplug operations since it identifies an object that
> > > > caused an issue in a log file.
> >
> > Hi Joe,
> >
> > Thanks for reviewing!
> >
> > > trivia:
> >
> > Did you mean to say something more on this? Just checking...
>
> No. I just intended to note that the comments that followed
> weren't particularly important nor should it really stop the
> patch from being applied if you didn't want to update it.
>
> cheers, Joe
Thanks Joe for the clarification and suggestion. If the dynamic debug
change becomes something non-trivial, I will postpone it.
-Toshi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/