Re: [PATCH] checkpatch: Update alignment check

[Paul Walmsley]

Hi Andy, Joe,

On Wed, 13 Jun 2012, Joe Perches wrote:

> Parenthesis alignment doesn't correctly check an existing line
> after an inserted or modified line with an open parenthesis.
> 
> Fix it.
> 
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Reviewed-by: Paul Walmsley <paul@xxxxxxxxx>
Tested-by: Paul Walmsley <paul@xxxxxxxxx>

This fixes some bogus checkpatch warnings here.  Andy, any chance this 
patch can make it in for 3.6-rc?

> ---
>  scripts/checkpatch.pl |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index e5bd60f..630319a 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1848,8 +1848,8 @@ sub process {
>  
>  			my $pos = pos_last_openparen($rest);
>  			if ($pos >= 0) {
> -				$line =~ /^\+([ \t]*)/;
> -				my $newindent = $1;
> +				$line =~ /^(\+| )([ \t]*)/;
> +				my $newindent = $2;
>  
>  				my $goodtabindent = $oldindent .
>  					"\t" x ($pos / 8) .
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/