Re: [PATCH 1/2] sched: recover SD_WAKE_AFFINE inselect_task_rq_fair and code clean up

[Mike Galbraith]

On Thu, 2012-07-26 at 13:27 +0800, Alex Shi wrote:

> 	if (affine_sd) {
> -		if (cpu == prev_cpu || wake_affine(affine_sd, p, sync))
> +		if (wake_affine(affine_sd, p, sync))
>  			prev_cpu = cpu;
>  
>  		new_cpu = select_idle_sibling(p, prev_cpu);

Hm, if cpu == prev_cpu, asking wake_affine() if it's ok to put wakee
back where it came from is wasted cycles.. that's where the task is
headed regardless of reply.

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/