Re: [PATCH V3 0/4] [SCSI] ufs: Adds glue drivers to ufshcd

[S, Venkatraman]

On Thu, Jul 26, 2012 at 4:42 PM, vinayak holikatti
<vinholikatti@xxxxxxxxx> wrote:
> On Thu, Jul 26, 2012 at 4:02 PM, S, Venkatraman <svenkatr@xxxxxx> wrote:
>> On Thu, Jul 26, 2012 at 2:12 PM, Vinayak Holikatti
>> <vinholikatti@xxxxxxxxx> wrote:
>>> This patch set adds following features
>>>  - Seggregate PCI specific code in ufshcd.c
>>>  - Adds PCI glue driver ufshcd-pci.c and ufshcd.c become core module
>>>  - Adds Platform glue driver ufshcd-pltfrm.c
>>>  - Update correct transfer size in Command UPIU
>>>
>>> Vinayak Holikatti (4):
>>>   [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code
>>>   [SCSI] drivers/scsi/ufs: Separate PCI code into glue driver
>>>   [SCSI] ufs: Add Platform glue driver for ufshcd
>>>   [SCSI] ufs: Correct the expected data transfer size
>>>
>>>  drivers/scsi/ufs/Kconfig         |   37 +++-
>>>  drivers/scsi/ufs/Makefile        |    2 +
>>>  drivers/scsi/ufs/ufshcd-pci.c    |  228 ++++++++++++++++++++
>>>  drivers/scsi/ufs/ufshcd-pltfrm.c |  222 ++++++++++++++++++++
>>>  drivers/scsi/ufs/ufshcd.c        |  422 ++++++--------------------------------
>>>  drivers/scsi/ufs/ufshcd.h        |  206 +++++++++++++++++++
>>>  drivers/scsi/ufs/ufshcd_common.h |   53 +++++
>>>  7 files changed, 813 insertions(+), 357 deletions(-)
>>
>> Two minor observations..
>> 1) If both pci and platform have to do the exact same thing in their
>> _suspend() and _resume() routines, perhaps there is scope for making
>> them as common (the steps outlined in them should be done in core
>> ufshcd) ?
> Both will not have to do the exact same thing. We have plan to implement
> ufshcd_suspend and ufshcd_resume which will be generic and will be part
> of ufshcd core, as you said.

Thanks. The comments in the driver files don't reflect this; it'd be
wise to create
the placeholder for core_suspend()/resume() in ufshcd.c, instead of
the platform drivers.

>>
>> 2) Need to include ufshcd_common.h in ufshcd.c so that the prototypes
>> are supplied for the exported functions.
> Thank you, I will make necessary changes in next version of patches.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/