Re: [PATCH] cpuidle: coupled: fix sleeping while atomic in cpu notifier

From: Shilimkar, Santosh
Date: Thu Jul 26 2012 - 18:54:58 EST


On Thu, Jul 26, 2012 at 9:25 AM, Shilimkar, Santosh
<santosh.shilimkar@xxxxxx> wrote:
> On Wed, Jul 25, 2012 at 11:20 PM, Colin Cross <ccross@xxxxxxxxxxx> wrote:
>> The cpu hotplug notifier gets called in both atomic and non-atomic
>> contexts, it is not always safe to lock a mutex. Filter out all events
>> except the six necessary ones, which are all sleepable, before taking
>> the mutex.
>>
>> Signed-off-by: Colin Cross <ccross@xxxxxxxxxxx>
>> ---
> Agree.
> Have you observed any lock-up ?
>
Colin explained me about cause of the issue in an off-list discussion.
Thought of updating the thread in case some one wants to reproduce the
issue. You get a warning during cpu hotplug in suspend if you turn on
sleeping while atomic debugging option in kernel build and the patch
fixes it.

Regards
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/