Re: [PATCH 3/6] OF: pinctrl: MIPS: lantiq: adds support for FALCON SoC

[Linus Walleij]

On Tue, Jul 24, 2012 at 8:50 AM, John Crispin <blogic@xxxxxxxxxxx> wrote:

> Implement support for pinctrl on lantiq/falcon socs. The FALCON has 5 banks
> of up to 32 pins.
>
> Signed-off-by: John Crispin <blogic@xxxxxxxxxxx>
> Signed-off-by: Thomas Langer <thomas.langer@xxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: devicetree-discuss@xxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx

No big issues and looking really sweet so:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

> --- a/arch/mips/lantiq/Kconfig
> +++ b/arch/mips/lantiq/Kconfig
> @@ -20,6 +20,7 @@ config SOC_XWAY
>
>  config SOC_FALCON
>         bool "FALCON"
> +       select PINCTRL_FALCON

I think you need to add "select PINCTRL" above "select PINCTRL_FALCON"
for this to work.

Atleast I had to do that in the past to get things working.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/