Re: [PATCH 2/3] regmap: implement irq chip suspend/resume operations

From: Mark Brown
Date: Sun Jul 29 2012 - 17:04:10 EST


On Fri, Jul 27, 2012 at 01:01:55PM -0600, Stephen Warren wrote:

> When suspending, we set up the wake mask registers as required. Some
> chips don't have separate wake mask registers, so they set mask_base
> equal to wake_base. In that case, when resuming, we re-program the

No, they shouldn't be doing that at all - that's at best confused. The
two registers do different things and if the two ranges are set the same
then I'd not expect things to work. Supporting that would make the code
more complex and I'm not sure what benefit we might gain from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/