Re: [PATCH 15/15] workqueue: deprecate __cancel_delayed_work()

From: Tejun Heo
Date: Tue Jul 31 2012 - 13:11:45 EST


On Tue, Jul 31, 2012 at 04:05:39PM +0300, Tomi Valkeinen wrote:
> > Use cancel_delayed_work() instead of __cancel_delayed_work() and mark
> > the latter deprecated.
>
> I used __cancel_delayed_work() in drivers/video/omap2/dss/dsi.c as the
> cancel is done in an interrupt handler. Is it safe to use
> cancel_delayed_work() in atomic context? I presume not, as it uses
> del_timer_sync().

Ah, you're right. __cancel_delayed_work() invoked from irq context
can't be converted to cancel_delayed_work() or mod_delayed_work().
I'll skip those from the previous patch and drop this patch. I really
hope this could be solved somehow tho. :(

Thank you.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/