Re: [PATCH 1/2] uprobes: Use a helper instead of ptrace's singlestep enable

From: Oleg Nesterov
Date: Tue Jul 31 2012 - 14:22:46 EST


On 07/31, Sebastian Andrzej Siewior wrote:
>
> +void __weak arch_uprobe_enable_step(struct task_struct *child,
> + struct arch_uprobe *arch)
> +{
> + user_enable_single_step(current);
> +}
> +
> +void __weak arch_uprobe_disable_step(struct task_struct *child,
> + struct arch_uprobe *arch)
> +{
> + user_disable_single_step(child);
> +}

I don't think this needs "struct task_struct *child", it is always
current "by definition". Only current can play with ->utask.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/