Re: [PATCH 01/14] aoe: for performance support larger packetpayloads

[Andrew Morton]

On Fri, 17 Aug 2012 21:18:37 -0400
Ed Cashin <ecashin@xxxxxxxxxx> wrote:

> --- a/drivers/block/aoe/aoeblk.c
> +++ b/drivers/block/aoe/aoeblk.c
> @@ -279,6 +279,9 @@ aoeblk_gdalloc(void *vp)
>  	if (bdi_init(&d->blkq->backing_dev_info))
>  		goto err_blkq;
>  	spin_lock_irqsave(&d->lock, flags);
> +	blk_queue_max_hw_sectors(d->blkq, BLK_DEF_MAX_SECTORS);
> +	d->blkq->backing_dev_info.ra_pages = BLK_DEF_MAX_SECTORS * 1024;
> +	d->blkq->backing_dev_info.ra_pages /= PAGE_CACHE_SIZE;

This seems a bit abusive of BLK_DEF_MAX_SECTORS, which is in units of
512-byte sectors.  (BLK_DEF_MAX_SECTORS * 512)/PAGE_CACHE_SIZE would
make sense.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/