Re: [PATCH 1/2] dw_dmac: make driver endianness configurable

[Hein Tibosch]

On 8/27/2012 3:03 PM, Hans-Christian Egtvedt wrote:
> I think the English in kconfig could use some brushing up.
>  
>> +config DW_DMAC_BE
>
>
> This name isn't that long, so we could skip the abbreviation of big endian;
> DW_DMAC_BIG_ENDIAN_IO or something similar?
>
>> +	bool "Synopsys DesignWare AHB DMA needs big endian access"
>>
> bool "Use big endian I/O register access"

Brushing up the config items:

+config DW_DMAC_BIG_ENDIAN_IO
+	bool "Use big endian I/O register access"
+	default y if AVR32
+	depends on DW_DMAC
+	help
+	  Say yes here to use big endian I/O access when reading and writing
+	  to the DMA controller registers. This is needed on some platforms,
+	  like the Atmel AVR32 architecture.
+
+	  If unsure, use the default setting.

And as I'd like to define the maximum memory transfer width in the same
Kconfig:

+config DW_DMAC_MEM_64_BIT
+	bool "Allow 64-bit memory transfers"
+	default y if !AVR32
+	depends on DW_DMAC
+	help
+	  Say yes if the DMA controller may do 64-bit memory transfers
+	  For AVR32, say no because only up to 32-bit transfers are
+	  defined

Would this be better?

Thanks, Hein
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/