Re: [PATCH 1/2] x86/mce: Pack boolean MCE boot flags into a structure

[Naveen N. Rao]

On 08/27/2012 09:17 PM, Borislav Petkov wrote:
> On Mon, Aug 27, 2012 at 09:05:46PM +0530, Naveen N. Rao wrote:
> > > > +
> > > > +extern struct mce_boot_flags mce_boot_flags;
> > >
> > > Why do we need that extern thing?
> >
> > So that this is visible across mce.c and mce_intel.c?
>
> Ok. But if you move the struct to mce-internal.h and since both .c files
> include it, we shouldn't need that extern, right?

I'm not sure I understand. I think we still need it. This is not about 
the structure, but the variable itself. extern allows mce_boot_flags 
_variable_ accessible from mce_intel.c.


Thanks,
Naveen

> I think that'll be the most optimal placement for now.
>
> Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/