Re: [PATCH] decnet: fix shutdown parameter checking

From: David Miller
Date: Fri Aug 31 2012 - 15:57:13 EST


From: Steven Whitehouse <swhiteho@xxxxxxxxxx>
Date: Mon, 27 Aug 2012 10:16:41 +0100

> On Sun, 2012-08-26 at 22:37 -0400, Xi Wang wrote:
>> The allowed value of "how" is SHUT_RD/SHUT_WR/SHUT_RDWR (0/1/2),
>> rather than SHUTDOWN_MASK (3).
>>
>> Signed-off-by: Xi Wang <xi.wang@xxxxxxxxx>
> Acked-by: Steven Whitehouse <swhiteho@xxxxxxxxxx>

Applied to net-next.

> Although it could be argued that we should also continue to accept the
> value 3 just in case there is any userland software out there which
> sends that value,

True, but this is a rather standard BSD socket interface with a very
specific small set of legitimate input parameters. Allowing
deviation, even for compatability for specific protocols, is largely
unwise.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/