Re: [PATCH 44/74] lto: Mark functions used by the vsyscall init code visible

From: Andi Kleen
Date: Sat Sep 01 2012 - 13:26:22 EST


On Sat, Sep 01, 2012 at 07:16:45PM +0200, Andi Kleen wrote:
> > I think that there should be a comment why the symbol needs to be
> > visible (just copy the reasoning from the changelog). Otherwise someone
> > might attempt to do a cleanup a few years later, noticing that there is
> > no assembler code calling get_random_int().
>
> Ok. On hindsight maybe it's better to split vsyscall_64.c into two
> files, one only with the vsyscall code and another with the init code.

Or checking the code again it's already done because only the emulation
is left and that is already a separate file. I'll drop those patches.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/