[PATCH 0/7] uprobes: single-step fixes

[Oleg Nesterov]

Hello.

In short: uprobes should not use user_enable/disable_single_step().
This is unneeded and wrong.

Sebastian, I changed your patches a bit:

	1/7:

		- Change the subject and update the changelog. In particular,
		  s/utrace/uprobes/. I am wondering where this typo came from ;)

	2/7:

		- Rename UPROBE_TF_CHANGES to UPROBE_FIX_SETF to match other
		  *_FIX_* defines.

		- Update the changelog.

		- !!!REMOVE send_sig(SIGTRAP) from arch_uprobe_disable_step!!!
		  Didn't I ask you to make a separate patch for this change? ;)

		  This "else send_sig(SIGTRAP)" is very wrong. Just suppose an
		  application does asm ("pushf; popf") and the 2nd insn is probed.
		  And otoh this is not enough.

		  See 6/7.

please let me know if you disagree.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/