RE: [PATCH] gpio:clk: preparation for switch to common clockframework

From: Karicheri, Muralidharan
Date: Mon Sep 03 2012 - 18:16:02 EST


>> -----Original Message-----
>> From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx]
>> Sent: Friday, August 31, 2012 7:14 PM
>> To: Karicheri, Muralidharan; Hilman, Kevin; Nori, Sekhar
>> Cc: grant.likely@xxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; mturquette@xxxxxxxxxx
>> Subject: Re: [PATCH] gpio:clk: preparation for switch to common clock framework
>>
>> On Thu, Aug 30, 2012 at 8:03 PM, Murali Karicheri <m-karicheri2@xxxxxx> wrote:
>>
>> > As a first step towards migrating davinci platforms to use common clock
>> > framework, replace all instances of clk_enable() with clk_prepare_enable()
>> > and clk_disable() with clk_disable_unprepare(). Until the platform is
>> > switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just
>> > adds a might_sleep() call and would work without any issues.
>> >
>> > This will make it easy later to switch to common clk based implementation
>> > of clk driver from DaVinci specific driver.
>> >
>> > Signed-off-by: Murali Karicheri <m-karicheri2@xxxxxx>
>>
>> OK the patch is so obviously correct so I just applied it, DaVinci folks,
>> scream if you still don't want it for some reason...
>>
Linus,

Thanks for applying this patch.

Murali Karicheri
Software Design Engineer
>> Yours,
>> Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/