Re: [PATCH] USB: ohci-at91: fix PIO handling in relation with numberof ports

From: Alan Stern
Date: Tue Sep 04 2012 - 10:34:39 EST


On Tue, 4 Sep 2012, Nicolas Ferre wrote:

> On 08/29/2012 11:49 AM, Nicolas Ferre :
> > If the number of ports present on the SoC/board is not the maximum
> > and that the platform data is not filled with all data, there is
> > an easy way to mess the PIO setup for this interface.
> > This quick fix addresses mis-configuration in USB host platform data
> > that is common in at91 boards since commit 0ee6d1e (USB: ohci-at91:
> > change maximum number of ports) that did not modified the associatd
> > board files.
> >
> > Reported-by: Klaus Falkner <klaus.falkner@xxxxxxxxxxxx>
> > Signed-off-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> > Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Cc: linux-usb@xxxxxxxxxxxxxxx
> > Cc: Stable <stable@xxxxxxxxxxxxxxx> [3.4+]
>
> Alan, Greg, gentle ping...
>
> I really would like to seen it landing in stable soon...
>
> Thanks, best regards,

Sorry for the delay. I feel a little uncomfortable judging board-level
changes like this, since I know nothing about the hardware details.

Still, for what it's worth, this patch is okay as far as the core
ohci-hcd driver components are concerned. So...

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/