Re: [PATCH 2/3] staging/vme: Use pr_ printks in vme_user.c

From: Greg Kroah-Hartman
Date: Tue Sep 04 2012 - 16:23:17 EST


On Tue, Aug 21, 2012 at 08:12:53PM +0900, Toshiaki Yamane wrote:
> The below checkpatch warnings was fixed,
>
> -WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
> -WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
> -WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
> -WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
>
> and added pr_fmt.

A lot of these can be converted to use dev_info(), dev_debug(),
dev_warn(), and dev_err() instead. Please do that whenever you have
access to a struct device.

So, sorry, I can't take this patch.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/