Re: [PATCH] kernel/sys.c: call disable_nonboot_cpus inkernel_restart

[Andrew Morton]

On Mon,  3 Sep 2012 22:24:58 +0800
Shawn Guo <shawn.guo@xxxxxxxxxx> wrote:

> Like kernel_power_off calls disable_nonboot_cpus, we may want to have
> kernel_restart call disable_nonboot_cpus as well.  Doing so can help
> the machines that require boot cpu be the last alive cpu during reboot
> to survive with kernel restart.

That does sound logical.  But the changelog is very vague and fluffy. 
Does this patch actually fix any known problem on any known machine?

> ...
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -368,6 +368,7 @@ EXPORT_SYMBOL(unregister_reboot_notifier);
>  void kernel_restart(char *cmd)
>  {
>  	kernel_restart_prepare(cmd);
> +	disable_nonboot_cpus();
>  	if (!cmd)
>  		printk(KERN_EMERG "Restarting system.\n");
>  	else

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/