Re: [RFC v2 PATCH 1/7] thp: remove assumptions on pgtable_t type

[Andrea Arcangeli]

Hi Gerald,

On Wed, Aug 29, 2012 at 05:32:58PM +0200, Gerald Schaefer wrote:
> +#ifndef __HAVE_ARCH_PGTABLE_DEPOSIT
> +extern void pgtable_deposit(struct mm_struct *mm, pgtable_t pgtable);
> +#endif

One minor nitpick on the naming of the two functions: considering that
those are global exports, that they can only be used by THP and they
mangle internally with the mm->pmd_huge_pte field (also only defined
if TRANSPARENT_HUGEPAGE=y), a more specific THP naming may be clearer.

If the current prepare_pmd_huge_pte/get_pmd_huge_pte wasn't good other
options could be pgtable_trans_huge_deposit/withdraw.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/