Re: [PATCHv2 0/4] Fix ACPI BGRT support for images located in EFIboot services memory

[Josh Triplett]

On Tue, Sep 04, 2012 at 02:21:19PM -0700, Josh Triplett wrote:
> v2: Made the new internal function efi_unmap_memmap static.  Incorporated
>     feedback from H. Peter Anvin and Matt Fleming: added stubs for
>     x86-specific EFI functions called from init/main.c to eliminate the
>     corresponding ifdefs in start_kernel; deferred
>     efi_free_boot_services even later, to just before free_initmem.

Argh, looks like I missed something important in testing: a WARN from
check_early_ioremap_leak.  Looks like moving the reclamation of the EFI
memory map that late makes check_early_ioremap_leak figure that it won't
get reclaimed at all.

As far as I can tell, ioremap won't work that early; EFI really does
need to use early_ioremap.  Since at the moment we don't seem to have
any other drivers that need to access boot services memory, any
objection to moving efi_free_boot_services back to just after ACPI?

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/