Re: [RFC PATCH 17/17] input: RMI4 F54 analog data reporting

[Christopher Heiny]

On 08/27/2012 04:01 PM, Linus Walleij wrote:
> > >Signed-off-by: Christopher Heiny<cheiny@xxxxxxxxxxxxx>
> > >+#include <linux/hrtimer.h>
> > >+#include <linux/kernel.h>
> > >+#include <linux/rmi.h>
> > >+#include <linux/slab.h>
> > >+#include <linux/version.h>
> > >+#include <linux/delay.h>
> This is not using the existing in-kernel framework for ADC (which I think is
> what you're doing), in this case use the IIO subsystem so consult
> drivers/iio/adc and be inspired.
>
> Just exposing a set of weird sysfs files to userspace is not proper.

I don't think the Industrial I/O ADC framework is appropriate for this. 
 F54 isn't intended to provide access to a general purpose ADC feature, 
but rather for diagnostic access to the touchscreen's capacitive sense 
features, which results in a fairly weird (as you noticed) interface. 
Trying to hammer on it to fit into iio/adc would require a lot of 
effort, and wind up making it look like something it really isn't.

However, it makes sense to move this whole interface to debugfs, given 
its intended model of use.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/