Re: [PATCH] Chinese translation of Documentation/gpio.txt

[Dong Aisheng]

Hi Wei,

On Tue, Aug 28, 2012 at 10:03:13PM +0800, Ninja Tekkaman wrote:
> This is a Chinese translated version of Documentation/gpio.txt
> 
> Signed-off-by: Fu Wei <tekkamanninja@xxxxxxxxx>
> ---
>  Documentation/zh_CN/gpio.txt |  662 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 662 insertions(+)
>  create mode 100644 Documentation/zh_CN/gpio.txt
> 
The doc mostly looks good.
A few minor comments.

> +èæäæèåçææèåçæåïèéåæåæçååäçää GPIO èç
> +ää platform_device æåçã
How about as follows?
èéåæåæçååäçäéçplatform_deviceæääççGPIOèçæåã

> +	/* GPIO èå:èåéæéé */
> +	int gpio_get_value(unsigned gpio);
> +
> +	/* GPIO èå */
èå

> +	void gpio_set_value(unsigned gpio, int value);
> +
> +èååæåååïéèçäçåïééèçéçåãåèåääèååèçåæï
GPIOåæååå

> +èåååèæåèäçåãèäåäææåèååççïåäåååæèåäåå
> +èåæäæçééã
èååèçéé

> +
> +ääç get/set åæääåææåçéè gpio_direction_*()æåâææç
> +GPIOâèåéèãæå,èéèææçæåäæææååéåääèååèäèå
> +ææçïéäåèääææèåéãäåéäææååèé(åèääç)ç GPIO
> +(èäæ)äçèäåææéèçã
ääç get/set åæææéèèååïåääågpio_direction_*()åçææè
æåæâææçGPIOâãæå,èéèææçæåäæææååéåääèååè
äèåææçïåääèèçåèææèåéãåå,åéäåäçç(èäæï
çæåääèååèéçGPIOäçèäåææéèçã

> +ääèéèç GPIO,åæåäääåäåçåæ:
> +
> +	/* GPIO èå:èåéæéé ,åèääç */
> +	int gpio_get_value_cansleep(unsigned gpio);
> +
> +	/* GPIO èå,åèääç */
èå

> +èäåæåæääåæççæãäææèéäåéäåää GPIO äççäåçï
> +èæääæååèæ;ççåèéèæååçäæåç GPIOïäæåäääää
ççåèæåçäåççGPIO

> +åäçèååäååååçéççåçåïææèçéèäç(åææææå)ã
> +(äå,æä GPIO ææåä IRQ äçã)ääççåéèææçææç:äçää
> +æéè gpio_direction_input()éçäèåç GPIO çåïæèäçää
> +åéææägpio_to_irq()ç IRQ çåã
...
> +
> +èääæååæåèäåäåçåçååèçèçäèäæéãåääåäçã
> +
> +gpio_to_irq()èåçééèååääéç request_irq()æè free_irq()ã
> +åäéåéèæççåçåååäçåæåååèåç IRQ èæäãææ:IRQ
> +èåééæ IRQ æåçäéåïå IRQF_TRIGGER_FALLINGïççåéèå
> +äæåæã
> +
> +irq_to_gpio()èåçééèåååæéååäè gpio_get_value()æäçï
> +æåå IRQ ææèåæåååæææéåçæãæææäååäææåæå,æä
> +äåèåééåäçåã
> +
> +åäçèååäååååçéççåçåïææèçéèäç(åææææå)ã
> +(äå,æä GPIO ææåä IRQ äçã)ääççåéèææçææçï
> +äçääæéè gpio_direction_input()éçäèåç GPIO çåï
> +æèäçääåéææägpio_to_irq()ç IRQ çåã
It looks these 4 lines are duplicated and should be removed.

> +èäåäåäçæçæçåçæææäïéåæäççèéèäåçåèåææèé
> +åäçåçäççç GPIOãäå,èåç GPIO ç(ååååå)æåéâ12âï
äå,èåççGPIO æåéâ12â

BTW, i meet a few whitespace warnings when applying your patch and
the Chinese in Documentation/zh_CN/gpio.txt can not be read by my
VIM, i tried many character set config such as UTF-8 and VSCII,
but still mess code. But the Windows Notepad can read it.
I don't know the reason, probably you could check it.

Otherwise you can add my ack.
Acked-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/