Re: [PATCH 05/11 V5] workqueue: Add @bind arguement back withoutchange any thing

[Tejun Heo]

Hello,

On Wed, Sep 05, 2012 at 06:37:42PM +0800, Lai Jiangshan wrote:
> Ensure the gcwq->flags is only accessed with gcwq->lock held.
> And make the code more easier to understand.
>
> In all current callsite of create_worker(), DISASSOCIATED can't
> be flipped while create_worker().
> So the whole behavior is unchanged with this patch.

This doesn't change anything.  You're just moving the test to the
caller with comments there explaining how it won't change even if
gcwq->lock is released.  It seems more confusing to me.  The flag is
still protected by manager_mutex.  How is this an improvement?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/