Re: [PATCH] drm/exynos: fix double call ofdrm_prime_(init/destroy)_file_private

[Paul Menzel]

Dear Inki Dae,


Am Donnerstag, den 06.09.2012, 11:35 +0900 schrieb InKi Dae:

> 2012/9/6 Mandeep Singh Baines <msb@xxxxxxxxxxxx>:
> > The double invocations are incorrect but seem to be safe so I don't
> > think this will fix any bugs.
> >
> > Before:
> >
> > [    7.639366] drm_prime_init_file ee3675d0
> > [    7.639377] drm_prime_init_file ee3675d0
> > [    7.639507] drm_prime_destroy_file ee3675d0
> > [    7.639518] drm_prime_destroy_file ee3675d0
> > [    7.639802] drm_prime_init_file ee372390
> > [    7.639810] drm_prime_init_file ee372390
> > [    8.473316] drm_prime_init_file ee356390
> > [    8.473331] drm_prime_init_file ee356390
> >
> > After:
> >
> > [    6.363842] drm_prime_init_file edc2e5d0
> > [    6.363994] drm_prime_destroy_file edc2e5d0
> > [    6.364260] drm_prime_init_file edc2e750
> > [    8.004837] drm_prime_init_file ee36ded0
> >
> > Signed-off-by: Mandeep Singh Baines <msb@xxxxxxxxxxxx>
> > CC: StÃphane Marchesin <marcheu@xxxxxxxxxxxx>
> > CC: Pawel Osciak <posciak@xxxxxxxxxx>
> > CC: Inki Dae <inki.dae@xxxxxxxxxxx>
> > CC: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
> > CC: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx>
> > CC: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > CC: David Airlie <airlied@xxxxxxxx>
> > CC: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> 
> remove all CCs

I guess they were generated by some script. So they should be fine, no?

Mandeep, if you put CC in here those people should be CCed in real. `git
send-email` should take care of that but I do not see everyone in the CC
field. Or does `git send-email` use blind carbon copy (BCC) field?

> and can you send it again using text mode?

At least to the list it was send in plain text mode.

> your patch is messed up when I try to get patch file.

Everything is fine on my side. Especially since Mandeep used `git
send-email` which should do everything correctly.

> Thanks.
> Inki Dae

In your From address your name is written InKi with capital K. Which one
is correct?


Thanks,

Paul

Attachment: signature.asc
Description: This is a digitally signed message part